Skip to content

Conversation

@zephyrieal
Copy link

I've updated the docs of merge_asof to make it more intuitive and understandable for users. It highlights that on should be first sorted before calling it. Other sections were elaborated as well.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looking good!

Comment on lines +706 to +707
a numeric column, such as datetimelike, integer, or float. 'on'
or 'left_on' / 'right_on' must be given.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a numeric column, such as datetimelike, integer, or float. 'on'
or 'left_on' / 'right_on' must be given.
a numeric column, such as datetimelike, integer, or float. ``on``
or ``left_on`` / ``right_on`` must be given.

@rhshadrach rhshadrach added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Oct 26, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Merge_asof fails for unknow reason

2 participants